Cookie-problemer

Nu ville det jo være rart at se de andre funktioner også, men det her i VoteNow() giver ikke meget mening:

if(!$_REQUEST[action]) {
  if($_REQUEST[action] == "vote") {

Hvis $_REQUEST['action'] ikke er sat skal den tjekke om den er lig med vote?

Umiddelbart burde det være:

<?php
function VoteNow() {
  global $cookieprefix;
  if(isset($_REQUEST['action'])) {
    if($_REQUEST['action'] == "vote") {
      $conn = mysql_connect ("xxxxxxx","xxxxxxx","xxxxxxxx");
      mysql_select_db("boldsens_dk");
      mysql_query("UPDATE pollanswer SET hits = hits+1 WHERE questionid = '$_REQUEST[questionid]' AND id = '$_REQUEST[id]'");
      mysql_close($conn);
      setcookie($cookieprefix."stem", "true", time()+999999);
    }
  }
}
?>

Du kan prøve sådan her, for at se om den kommer ind i if'en:
if(HaveVoted() != true) {
            echo "Har ikke stemt";
} else {
            echo "Har stemt";
}

Ja det er rettet. Sorry guys, men jeg opdagede lige en fejl i det jeg lagde ud før her kommer lige den opdaterede funktion. Nu er problemet, at jeg kun får muligheden for at stemme, og aldrig ser resultatet af afstemningen. Altså omvendt fra før. Sorry. Den udskriver altså her "har ikke stemt".

<?php
function VoteNow() {
  global $cookieprefix;
  if(isset($_REQUEST['action'])) {
    if($_REQUEST['action'] == "vote") {
      $conn = mysql_connect ("xxxxxxx","xxxxxxx","xxxxxxx");
      mysql_select_db("boldsens_dk");
      mysql_query("UPDATE pollanswer SET hits = hits+1 WHERE questionid = '$_REQUEST[questionid]' AND id = '$_REQUEST[id]'");
      mysql_close($conn);
      setcookie($cookieprefix."stem", "true", time()+999999);
    }
  }
}
?>

<?
              if(HaveVoted() == true) {
            echo VoteNow();
            echo ShowResults();
            } else {
            echo ShowPoll();
            }
           
            if(HaveVoted() == true) {
                        echo "Har stemt";
            } else {
                        echo "Har ikke stemt";
            }
                       
            function HaveVoted() {
            global $cookieprefix;
            if($_COOKIE[$cookieprefix."stem"]) {
            return true;
            } else {
            return false;
            }
            }
?>

Og her kommer resten:


function ShowResults() {

########## POLL QUESTION ##########

$kode .= "<table>\n";
$conn = mysql_connect ("xxxxxxx","xxxxxx","xxxxxxx");
mysql_select_db("boldsens_dk");
$result = mysql_query("select * from pollquestion WHERE start <= now() AND end >= now()");
while ($row = mysql_fetch_array($result)) {
$kode .= "<tr><td colspan=\"2\">" . htmlentities($row["question"]) . "</td></tr>\n";

$questionid = $row["questionid"];
}

########## SUM OF POLLANSWERS ##########

$result = mysql_query("select sum(hits) as hits from pollanswer where questionid = '$questionid'");
while ($row = mysql_fetch_array($result)) {
  $sum = $row["hits"];
 

}

$result = mysql_query("select * from pollanswer WHERE questionid = '$questionid'");
while ($row = mysql_fetch_array($result)) {
  $percent = 0;
  if($row["hits"] > 0) {
    $percent = ($row["hits"] * 100) / $sum;
  }
    $kode .= "<tr><td>" . htmlentities($row["answer"]) . "</td>";
    $kode .= '<td><img src="hl.jpg" style="width: ' . $percent . 'px; height: 12px; border: 0px;" alt=""></td>';
    $kode .= "<td>" . round($percent , 1). "%</td></tr>\n";
   
}
  $kode .= "<td><tr><td colspan=\"2\">$sum stemme(r) i alt</td></tr>\n";
mysql_close($conn);

$kode .= "</table>\n";

########## VOTE ##########

if($_REQUEST[action] == "vote") {
$conn = mysql_connect ("xxxxxx","xxxxxx","xxxxxxx");
  mysql_select_db("boldsens_dk");
  mysql_query("UPDATE pollanswer SET hits = hits + 1 WHERE questionid = '$_REQUEST[questionid]' AND id = '$_REQUEST[id]'");
  mysql_close($conn);
}
return $kode;
}


function ShowPoll() {
    ########## POLL QUESTION ##########
   
    $kode .=  "<form action=\"index.php?action=vote\" method=\"post\">\n";
    $kode .= "<table>\n";
   
    $conn = mysql_connect("xxxxxxx", "xxxxxxx", "xxxxxxx");
    mysql_select_db("boldsens_dk");
    $result = mysql_query("select * from pollquestion WHERE start <= now() AND end >= now()");
   
    while ($row = mysql_fetch_array($result)) {
    $kode .= "<tr><td>" . htmlentities($row[question]) . "</td></tr>\n";
   
    $questionid = $row[questionid];
    }
?>
                </div></td>
            </tr>
          </table>
          <font size="1" face="Arial, Helvetica, sans-serif"><br>
          </font></div>
      </div>
      <div align="center"></div>
      <table width="181" cellspacing="0">
        <tr>
          <td width="148" font size="1" face="Arial, Helvetica, sans-serif">
            <?
    ########## POLL ANSWERS ##########
   
    $result = mysql_query("select * from pollanswer WHERE questionid = '$questionid'");
    while ($row = mysql_fetch_array($result)) {
    $kode .= "<tr><td><input type=\"radio\" name=\"id\" value=\"" . $row["id"] . "\">" . $row["answer"]."</td></tr>\n";
    }
    $kode .= "<tr><td><input type=\"hidden\" name=\"questionid\" value=\"$questionid\">\n";
?>
            <div align="center"> <font size="1" face="Arial, Helvetica, sans-serif">
              <?
    $kode .= "<br>";
    $kode .= "<input type=\"submit\" value=\"Stem\"></td></tr>\n";
    $kode .= "</table>\n";
    $kode .= "</form>\n";

    return $kode;
}
?>

Jeg har puslet lidt mere med det. Og nu er mit eneste problem, at man skal stemme 2 gange før man får vist sit afstemningsresultat. Koden ser sådan her ud:

<?php
  global $cookieprefix;
  if(isset($_REQUEST['action'])) {
    if($_REQUEST['action'] == "vote") {
      $conn = mysql_connect ("xxxxxxxx","xxxxxxxx","xxxxxxxx");
      mysql_select_db("boldsens_dk");
      mysql_query("UPDATE pollanswer SET hits = hits+1 WHERE questionid = '$_REQUEST[questionid]' AND id = '$_REQUEST[id]'");
      mysql_close($conn);
      setcookie($cookieprefix."stem", "true", time()+999999);
    }
  }
?>

<?
          function HaveVoted() {
            global $cookieprefix;
            if($_COOKIE[$cookieprefix."stem"]) {
            return true;
            } else {
            return false;
            }
            }
                                 
function ShowResults() {

########## POLL QUESTION ##########

$kode .= "<table>\n";
$conn = mysql_connect ("xxxxxxxx","xxxxxxxx","xxxxxxxx");
mysql_select_db("boldsens_dk");
$result = mysql_query("select * from pollquestion WHERE start <= now() AND end >= now()");
while ($row = mysql_fetch_array($result)) {
$kode .= "<tr><td colspan=\"2\">" . htmlentities($row["question"]) . "</td></tr>\n";

$questionid = $row["questionid"];
}

########## SUM OF POLLANSWERS ##########

$result = mysql_query("select sum(hits) as hits from pollanswer where questionid = '$questionid'");
while ($row = mysql_fetch_array($result)) {
  $sum = $row["hits"];
}

$result = mysql_query("select * from pollanswer WHERE questionid = '$questionid'");
while ($row = mysql_fetch_array($result)) {
  $percent = 0;
  if($row["hits"] > 0) {
    $percent = ($row["hits"] * 100) / $sum;
  }
    $kode .= "<tr><td>" . htmlentities($row["answer"]) . "</td>";
    $kode .= '<td><img src="Pics/bar.jpg" style="width: ' . $percent . 'px; height: 12px; border: 0px;" alt=""></td>';
    $kode .= "<td>" . round($percent , 1). "%</td></tr>\n";
}
  $kode .= "<td><tr><td colspan=\"2\">$sum stemme(r) i alt</td></tr>\n";
mysql_close($conn);

$kode .= "</table>\n";

########## VOTE ##########

if($_REQUEST[action] == "vote") {
$conn = mysql_connect ("xxxxxxxx","xxxxxxxx","xxxxxxxx");
  mysql_select_db("boldsens_dk");
  mysql_query("UPDATE pollanswer SET hits = hits + 1 WHERE questionid = '$_REQUEST[questionid]' AND id = '$_REQUEST[id]'");
  mysql_close($conn);
}
return $kode;
}

function ShowPoll() {
    ########## POLL QUESTION ##########
   
    $kode .=  "<form action=\"index.php?action=vote\" method=\"post\">\n";
    $kode .= "<table>\n";
   
    $conn = mysql_connect("xxxxxxxx", "xxxxxxxx", "xxxxxxxx");
    mysql_select_db("boldsens_dk");
    $result = mysql_query("select * from pollquestion WHERE start <= now() AND end >= now()");
   
    while ($row = mysql_fetch_array($result)) {
    $kode .= "<tr><td>" . htmlentities($row[question]) . "</td></tr>\n";
   
    $questionid = $row[questionid];
    }

    ########## POLL ANSWERS ##########
   
    $result = mysql_query("select * from pollanswer WHERE questionid = '$questionid'");
    while ($row = mysql_fetch_array($result)) {
    $kode .= "<tr><td><input type=\"radio\" name=\"id\" value=\"" . $row["id"] . "\">" . $row["answer"]."</td></tr>\n";
    }
    $kode .= "<tr><td><input type=\"hidden\" name=\"questionid\" value=\"$questionid\">\n";

    $kode .= "<br>";
    $kode .= "<input type=\"submit\" value=\"Stem\"></td></tr>\n";
    $kode .= "</table>\n";
    $kode .= "</form>\n";

    return $kode;
}

            if(HaveVoted() == true) {
            echo ShowResults();
            } else {
            echo ShowPoll();
            }
           
            if(HaveVoted() == true) {
                        echo "Du har stemt";
            } else {
                        echo "Du har ikke stemt";
            }
?>

Kan I gennemskue den?

Nå jeg fik løst svaret her: http://www.eksperten.dk/spm/562820