if ens validering i form

jeg har forsøgt følgene men virker ikke.

Nogen der kan hjælpe mig ??

<script language=\"JavaScript\" type=\"text/JavaScript\">

function isEmpty(string) {
return !/\S+/.test(string);
}

function validate(form) {
var controls = form.elements;

/* Requiring only one of either state or zip code seemed
* rather odd (though I'm not an American, admittedly), so
* the code below doesn't follow the original logic.
*/
if (controls.first.value == controls.second.value)
alert('You can select the same in first and second choice');
return false;
</script>

echo"<form name=\"form1\" method=\"post\" action=\"?action=joined&sid=$sid\" onsubmit=\"return validate(this);\">
<br><br><center><p>To join select 2 division for <br><br>Team $description from $clantag $clanname <br><br>1 st. choice &nbsp;
            <select id=\"first\">";
           
$get = mysql_query("select * from division WHERE season='$seasonnr' AND activdivision='1'");
echo "";
while($row = mysql_fetch_array($get)) {

print("<option value='".$row["division"]."'". ($row["division"] == $div ? " selected" : "") .">".$row["description"]."</option>");
//print("<option value='".$row[status]."' $var>".$row[name]."</option>");
}
print("</select>");

echo"<br><br> 2 nd. choice &nbsp;
            <select id=\"second\">";
           
$get = mysql_query("select * from division WHERE season='$seasonnr' AND activdivision='1'");
echo "";
while($row = mysql_fetch_array($get)) {

print("<option value='".$row["division"]."'". ($row["division"] == $div ? " selected" : "") .">".$row["description"]."</option>");
//print("<option value='".$row[status]."' $var>".$row[name]."</option>");
}
print("</select>");
           
            echo"<br><br><input name=\"submit\" type=\"submit\" value=\"Signup season $seasonnr &nbsp;\"></form></center></p><br><br>
            <p>Join rules.<br><br>The joining team must have at least 5 members that has approved punkbuster guid.<br><br>
            The staff will check this before the team will be set into there division and activated.
            </p>";