Avatar billede webcreator Nybegynder
10. juni 2003 - 16:16 Der er 11 kommentarer og
2 løsninger

Fejl i upload-script. T_ELSE

Hej.

Jeg har nogle problemer med at få et upload script til at virke. Jeg starter med at give en del af koden, da jeg mener fejlen ligger her :

if ($pass == $pass2) {

  include("upload-cfg.php");
 
  if (file_exists("$absolute_path/$file_name")) {
  header("location:add-member.php?uds=Please rename your image-file&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
  } else {
 
  if (($size_limit == "yes") && ($limit_size < $file_size)) {
  header("location:add-member.php?uds=Filesize not allowed&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
  } else {
 
  @copy($file, "$absolute_path/$file_name") or header("location:add-member.php?uds=Error - Contact an administrator&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
  }
 
  $insertSQL = "insert into members (name, function, birthday, location, connection, favouritew, favouritem, quote, image, groups, nick, pass)
                values ('$name', '$function', '$birthday', '$location', '$connection', '$favouritew', '$favouritem', '$quote', '$file_name', '$groups', '$nick', '$pass')";
  mysql_query($insertSQL) or die (mysql_error());

} else {
header("location:add-member.php?uds=Error - Contact an administrator&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
}

Fejlen lyder :

Parse error: parse error, unexpected T_ELSE in /web/www/frac/users/jemt/klan/add-member-db.php on line 63
Avatar billede ahv Nybegynder
10. juni 2003 - 16:18 #1
Lidt mere kode, fra linie 1 til 70 ville være fint.
Avatar billede ahv Nybegynder
10. juni 2003 - 16:24 #2
Men måske, det skal være sådan her, lige nu har du hvertfald en else på en else hvilket ikke går, prøv:


if ($pass == $pass2) {
    include("upload-cfg.php");
    if (file_exists("$absolute_path/$file_name")) {
        header("location:add-member.php?uds=Please rename your image-file&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
    } else {
        if (($size_limit == "yes") && ($limit_size < $file_size)) {
            header("location:add-member.php?uds=Filesize not allowed&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
        } else {
            @copy($file, "$absolute_path/$file_name") or header("location:add-member.php?uds=Error - Contact an administrator&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
            mysql_query("insert into members (name, function, birthday, location, connection, favouritew, favouritem, quote, image, groups, nick, pass) values ('$name', '$function', '$birthday', '$location', '$connection', '$favouritew', '$favouritem', '$quote', '$file_name', '$groups', '$nick', '$pass')") or die(mysql_error());
        }
    }
} else {
    header("location:add-member.php?uds=Error - Contact an administrator&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
}
Avatar billede ahv Nybegynder
10. juni 2003 - 16:25 #3
:o)
Avatar billede ohmish Nybegynder
10. juni 2003 - 16:25 #4
du har flere else sætninger i samme statement
Avatar billede ohmish Nybegynder
10. juni 2003 - 16:28 #5
if ($pass == $pass2) {

  include("upload-cfg.php");
 
  if (file_exists("$absolute_path/$file_name")) {
  header("location:add-member.php?uds=Please rename your image-file&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
} elseif (($size_limit == "yes") && ($limit_size < $file_size)) {
  header("location:add-member.php?uds=Filesize not allowed&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
  } else {
  @copy($file, "$absolute_path/$file_name") or header("location:add-member.php?uds=Error - Contact an administrator&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
  }

  $insertSQL = "insert into members (name, function, birthday, location, connection, favouritew, favouritem, quote, image, groups, nick, pass) values ('$name', '$function', '$birthday', '$location', '$connection', '$favouritew', '$favouritem', '$quote', '$file_name', '$groups', '$nick', '$pass')";
  mysql_query($insertSQL) or die (mysql_error());

} else {
header("location:add-member.php?uds=Error - Contact an administrator&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
}
Avatar billede Slettet bruger
10. juni 2003 - 16:31 #6
Sikke en gang rod.
Avatar billede webcreator Nybegynder
10. juni 2003 - 16:32 #7
Ja, i har ret i, at der var en else for meget :)
Og den kan self. bare smides væk, da jeg får samme hændelse i :
@copy($file, "$absolute_path/$file_name")-sætningen. (Efter or)

Men det giver fejl i linie 74 :
Parse error: parse error, unexpected $ in /web/www/frac/users/jemt/klan/add-member-db.php on line 74

Men jeg har altså ikke 74 linier.

Nu får i hele koden :

<?php

include("config.php");

$adminnick  = $_REQUEST["adminnick"];
$adminpass  = $_REQUEST["adminpass"];

$name      = $_REQUEST["name"];
$function  = $_REQUEST["function"];
$birthday  = $_REQUEST["birthday"];
$location  = $_REQUEST["location"];
$connection = $_REQUEST["connection"];
$favouritew = $_REQUEST["favouritew"];
$favouritem = $_REQUEST["favouritem"];
$quote      = $_REQUEST["quote"];
$groups    = $_REQUEST["groups"];
$nick      = $_REQUEST["nick"];
$pass      = $_REQUEST["pass"];
$pass2      = $_REQUEST["pass2"];

$b = mysql_query("SELECT * FROM members where nick = '$adminnick'") or die(mysql_error());
$rowb = mysql_fetch_array($b);
$passdb = $rowb["pass"];
$groupdb = $rowb["groups"];

/*
if (($adminnick == "") || ($adminpass == "") || ($name == "") || ($function == "") || ($birthday == "") || ($location == "") || ($connection == "") || ($favouritew == "") || ($favouritew == "") || ($favouritem == "") || ($quote == "") || ($groups == "") || ($nick == "") || ($pass == "") || ($pass2 == "")) {
header("location:add-member.php?uds=Please fill out all fields&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
} else {

if ($adminpass != $passdb) {
header("location:add-member.php?uds=Wrong admin password&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
} else {

if ($groupdb != "Admin") {
header("location:add-member.php?uds=You are not using an admin account&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
} else {

if ($pass != $pass2) {
header("location:add-member.php?uds=Password1 and Password2 must be identical&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
} else {
*/

if ($pass == $pass2) {

  include("upload-cfg.php");
 
  if (file_exists("$absolute_path/$file_name")) {
  header("location:add-member.php?uds=Please rename your image-file&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
  } else {
 
  if (($size_limit == "yes") && ($limit_size < $file_size)) {
  header("location:add-member.php?uds=Filesize not allowed&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
  } else {
 
  @copy($file, "$absolute_path/$file_name") or header("location:add-member.php?uds=Error - Contact an administrator&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
  }
 
  $insertSQL = "insert into members (name, function, birthday, location, connection, favouritew, favouritem, quote, image, groups, nick, pass)
                values ('$name', '$function', '$birthday', '$location', '$connection', '$favouritew', '$favouritem', '$quote', '$file_name', '$groups', '$nick', '$pass')";
  mysql_query($insertSQL) or die (mysql_error());

#}
#}
#}
#}


mysql_close($conn);

header("location:add-member.php?uds=Member added to DB");

?>
Avatar billede ahv Nybegynder
10. juni 2003 - 16:38 #8
if ($pass == $pass2) {
    include("upload-cfg.php");
    if (file_exists("$absolute_path/$file_name")) {
        header("location:add-member.php?uds=Please rename your image-file&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
    } else {
        if (($size_limit == "yes") && ($limit_size < $file_size)) {
            header("location:add-member.php?uds=Filesize not allowed&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
        } else {
            @copy($file, "$absolute_path/$file_name") or header("location:add-member.php?uds=Error - Contact an administrator&adminnick=$adminnick&name=$name&function=$function&birthday=$birthday&location=$location&connection=$connection&favouritew=$favouritew&favouritem=$favouritem&quote=$quote&groups=$groups&nick=$nick");
        }
        $insertSQL = "insert into members (name, function, birthday, location, connection, favouritew, favouritem, quote, image, groups, nick, pass) values ('$name', '$function', '$birthday', '$location', '$connection', '$favouritew', '$favouritem', '$quote', '$file_name', '$groups', '$nick', '$pass')";
        mysql_query($insertSQL) or die (mysql_error());
    }
}
Avatar billede webcreator Nybegynder
10. juni 2003 - 16:39 #9
Hvor har du rettet en fejl ? Vil hellere have fejlen at vide, samt hvad den skal rettes til :-)
Avatar billede webcreator Nybegynder
10. juni 2003 - 16:39 #10
(Vil gerne lære en smule jo :-)
Avatar billede ahv Nybegynder
10. juni 2003 - 16:40 #11
Jeg indsatte to } til sidst, du skal jo huske at afslutte dine if/else statements
Avatar billede ohmish Nybegynder
10. juni 2003 - 17:08 #12
du behøver i virkligheden kun at ændre nr. 2 statement til elseif
Avatar billede webcreator Nybegynder
10. juni 2003 - 17:24 #13
YES. Endelig virker det. Jeg omskrev en del af koden. Den lugtede :-)

Men tak alligevel :-)
Avatar billede Ny bruger Nybegynder

Din løsning...

Tilladte BB-code-tags: [b]fed[/b] [i]kursiv[/i] [u]understreget[/u] Web- og emailadresser omdannes automatisk til links. Der sættes "nofollow" på alle links.

Loading billede Opret Preview
Kategori
Vi tilbyder markedets bedste kurser inden for webudvikling

Log ind eller opret profil

Hov!

For at kunne deltage på Computerworld Eksperten skal du være logget ind.

Det er heldigvis nemt at oprette en bruger: Det tager to minutter og du kan vælge at bruge enten e-mail, Facebook eller Google som login.

Du kan også logge ind via nedenstående tjenester