Avatar billede neo_bill Nybegynder
02. marts 2002 - 14:44 Der er 8 kommentarer og
1 løsning

Skummelt PHP

http://www.bre.dyndns.dk/clan/members.php?action=listall
Den her membersliste er genereret af den her kode som er includet i noget der virker finno.... Hvem kan finde flest fejl:

<?
include("config.php");
include("header.php");

if ($action == "") {members();}
elseif ($action == "listall") {membersListAll($order);}
elseif ($action == "listteam") {membersListTeam($team);}
elseif ($action == "showmember") {showmember($mm);}
elseif ($action == "msg") {msg($person);}
elseif ($action == "msg2") {msg2($person, $msg, $from);}
elseif ($action == "gbog") {gbog($person);}
elseif ($action == "gbog2") {gbog2($msg, $from1, $person, $email);}

include("footer.php");

function members() {
global $teams_table;
$query = mysql_query("SELECT * FROM $teams_table ORDER BY name");
if (mysql_num_rows($query) == 0) {$teams = "";}
else {
$teams = "By Team:<br>";
while ($team = mysql_fetch_array($query)) {
  $teams = $teams . "- <a href=\"members.php?action=listteam&team=" . $team['name'] . "\">" . $team['name'] . "</a> [Points: " . $team['points'] . "]<br>";
}
}
?>Members<hr><br>
<a href="members.php?action=listall">List All</a><br><br>
<?=$teams?>
<?
}
function showmember($mm) {
$query = mysql_query("SELECT * FROM TMC_members WHERE name='$mm'");
$data = mysql_fetch_array($query);
echo " <font face=verdana size=3> Her er " . $data['name'] . "s profil: </font><br><hr>";
echo ("<font><b>Nickname: </b><font><font>" . $data['name'] . "<br><br>" . "<b>" . $data['name'] . "'s alder: </b>" . $data['age'] . "<br><br>" . "<b>" . $data['name'] . "'s rigtige navn: </b>" . $data['rname'] . "<br><br><b>" . $data['name'] . "<font>'s text: </b> <br>" . $data['profildata'] . "</font><br><br><hr><br><center>-<a href=\"members.php?action=msg&person=" . $data['name'] . "\"> Send " . $data['name'] . " a message </a>-<a href=\"members.php?action=gbog&person=" . $data['name'] . "\"> View/sign guestbook </a>-</center>");
}
function msg($person) {
?>Send <? echo $person; ?> a message:<hr><br>
<b>Message:</b><br>
<form method="post" action=members.php>
<input type=hidden name=action value=msg2>
<input type=hidden name=person value=<? echo $person; ?>>
<b>Your Name:</b><br>
<input name=from size=50 value=" "><br>
<b>Your message(remember to write your Email or we cant reply):</b><br>
<textarea cols=70 rows=8 name=msg></textarea><br><br>
<input type=submit value="Send">
</form>
<?
}

function gbog($person) { ?>
Here is <? echo $person; ?>'s guestbook:<hr><br><?
include "config.php";
$query = mysql_query("SELECT * FROM TMC_gbog WHERE person='$person'");
while ($contest = mysql_fetch_array($query)) {
  $contests = $contests . "<tr><td><font size=2><a href=\"mailto:" . $contest['email'] . "\">" . $contest['from1'] . "</a></font></td><td><font size=2>" . $contest['msg'] . "</font></td></tr>";
}
?>
<table cellpadding=2 cellspacing=0 border=1 bordercolor=dimgray>
<tr>
<td><font size=2>From</font></td>
<td><font size=2>Message</font></td>
</tr>
<?=$contests?>
</table><br>
<hr>Sign <? echo $person; ?>'s guestbook:<hr><br>
<b>Sign these fields:</b><br>
<form method="post" action=members.php>
<input type=hidden name=action value="gbog2">
<input type=hidden name=person value="<?=$person;?>">
<b>Your Name:</b><br>
<input name=from1 size=50 value=""><br>
<b>Your email:</b><br>
<input name=email size=50 value="">
<b><br>Your message:</b><br>
<textarea cols=70 rows=8 name=msg></textarea><br><br>
<input type=submit value="Send">
</form>
<?
}

function gbog2($msg, $from1, $person, $email){
?>Guestbook 2<hr><br>
<?
include ("config.php");
$msg = str_replace("\n", "\<br\>", $msg);
$msg = str_replace("\'", "\\'", $msg);
$query = mysql_query("INSERT INTO TMC_gbog (msg, from1, person, email) VALUES ('$msg', '$from1', '$person', '$email')");
echo $query;
?>Message Inserted to guestbook!<?
}

function msg2($person, $msg, $from){
?>Message 2<hr><br>
<?
$msg = str_replace("\n", "\<br\>", $msg);
$msg = str_replace("\'", "\\'", $msg);
$query = mysql_query("INSERT INTO TMC_msg (msg, person, fra) VALUES ('$msg', '$person', '$from')");
?>Message sent!<?
}

function membersListAll($order) {
global $members_table;
?>All Members<hr><br>
<?
if ($order == "") {$query = mysql_query("SELECT * FROM $members_table");}
else {$query = mysql_query("SELECT * FROM $members_table ORDER BY $order");}
while ($member = mysql_fetch_array($query)) {
if ($member['team'] == "") {$member['team'] = "none";}
if ($member['email'] == ""){$member['email'] = "none";}
$members = $members . "<tr><td><font face=verdana size=2><a href=\"members.php?action=showmember&mm=" . $member['name'] . "\">" . $member['name'] . "</a>" . "</font></td>
<td><font face=verdana size=2>" .  $member['email'] . "</font></td>
<td><font face=verdana size=2>" . $member['team'] . "</font></td>
<td><font face=verdana size=2>" . $member['rank'] . "</font></td>
<td><font face=verdana size=2>" . $member['icq'] . "</font></td>
<td><font face=verdana size=2><input type=\"button\" name=\"button\" onClick=\"window.open('test.php?action=" . $member['name'] . "', 'toolbar=no,location=no,status=no,width=200,height=200')</font></td>
</tr>\n";
}
?>
<table cellpadding=2 cellspacing=0 border=1 bordercolor=#999999>
<tr>
<td><font face=verdana size=2><a href="members.php?action=listall&order=name">Member Name</a></font></td>
<td><font face=verdana size=2><a href="members.php?action=listall&order=email">Member Email</a></font></td>
<td><font face=verdana size=2><a href="members.php?action=listall&order=team">Member Team</a></font></td>
<td><font face=verdana size=2><a href="members.php?action=listall&order=rank">Member Rank</a></font></td>
<td><font face=verdana size=2><a href="members.php?action=listall&order=icq">Member ICQ</a></font></td>
<td><font face=verdana size=2>Skill</font></td>
</tr>
<?=$members?>
</table>
<?
}

function membersListTeam($team) {
global $members_table;
?>List Team <?=$team?><hr><br>
<?
$query = mysql_query("SELECT * FROM $members_table WHERE team='$team' AND rank='leader' ORDER BY name");
while ($member = mysql_fetch_array($query)) {
if ($member['team'] == "") {$member['team'] = "none";}
if ($member['email'] == ""){$member['email'] = "none";}
$members = $members . "<tr><td><font face=verdana size=2><a href=\"members.php?action=showmember&mm=" . $member['name'] . "\">" . $member['name'] . "</a>" . "</font></td>
<td><font face=verdana size=2>" .  $member['email'] . "</font></td>
<td><font face=verdana size=2>" . $member['team'] . "</font></td>
<td><font face=verdana size=2>" . $member['rank'] . "</font></td>
<td><font face=verdana size=2>" . $member['icq'] . "</font></td>
<td><font face=verdana size=2><input type=\"button\" name=\"button\" onClick=\"window.open('test.php?action=" . $member['name'] . "', 'toolbar=no,location=no,status=no,width=200,height=200')</font></td>
</tr>\n";
}
$query = mysql_query("SELECT * FROM $members_table WHERE team='$team' AND rank='team leader' ORDER BY name");
while ($member = mysql_fetch_array($query)) {
if ($member['team'] == "") {$member['team'] = "none";}
if ($member['email'] == ""){$member['email'] = "none";}
$members = $members . "<tr><td><font face=verdana size=2><a href=\"members.php?action=showmember&mm=" . $member['name'] . "\">" . $member['name'] . "</a>" . "</font></td>
<td><font face=verdana size=2>" .  $member['email'] . "</font></td>
<td><font face=verdana size=2>" . $member['team'] . "</font></td>
<td><font face=verdana size=2>" . $member['rank'] . "</font></td>
<td><font face=verdana size=2>" . $member['icq'] . "</font></td>
<td><font face=verdana size=2><input type=\"button\" name=\"button\" onClick=\"window.open('test.php?action=" . $member['name'] . "', 'toolbar=no,location=no,status=no,width=200,height=200')</font></td>
</tr>\n";
}
$query = mysql_query("SELECT * FROM $members_table WHERE team='$team' AND rank='clan member' ORDER BY name");
while ($member = mysql_fetch_array($query)) {
if ($member['team'] == "") {$member['team'] = "none";}
if ($member['email'] == ""){$member['email'] = "none";}
$members = $members . "<tr><td><font face=verdana size=2><a href=\"members.php?action=showmember&mm=" . $member['name'] . "\">" . $member['name'] . "</a>" . "</font></td>
<td><font face=verdana size=2>" .  $member['email'] . "</font></td>
<td><font face=verdana size=2>" . $member['team'] . "</font></td>
<td><font face=verdana size=2>" . $member['rank'] . "</font></td>
<td><font face=verdana size=2>" . $member['icq'] . "</font></td>
<td><font face=verdana size=2><input type=\"button\" name=\"button\" onClick=\"window.open('test.php?action=" . $member['name'] . "', 'toolbar=no,location=no,status=no,width=200,height=200')</font></td>
</tr>\n";
}
?>
<table cellpadding=2 cellspacing=0 border=1 bordercolor=#999999>
<tr>
<td><font face=verdana size=2>Member Name</font></td>
<td><font face=verdana size=2>Member Email</font></td>
<td><font face=verdana size=2>Member Team</font></td>
<td><font face=verdana size=2>Member Rank</font></td>
<td><font face=verdana size=2>Member ICQ</font></td>
<td><font face=verdana size=2>Skill</font></td>
</tr>
<?=$members?>
</table>
<?
}
?>



/ BRE
Avatar billede hathor Nybegynder
02. marts 2002 - 14:46 #1
daaaaaammn .. :-)

Gider godt nok ikke sidde og nærlæse det der :-)
Avatar billede tipsen Nybegynder
02. marts 2002 - 14:49 #2
troede ikke eksperten var til korrekturlæsning...

Hvad er problemet egentlig?
Avatar billede neo_bill Nybegynder
02. marts 2002 - 14:58 #3
Well det er at tabellen er megal-ol at se på.. men hvis man fjerner:

<td><font face=verdana size=2><input type=\"button\" name=\"button\" onClick=\"window.open('test.php?action=" . $member['name'] . "', 'toolbar=no,location=no,status=no,width=200,height=200')</font></td>

i de forskellige løkker så kører det :-/

ok hvad der er mere skummelt er at den i sourcen på http://www.bre.dyndns.dk/clan/members.php?action=listall ser  finno ud...?


/Eminem
Avatar billede neo_bill Nybegynder
02. marts 2002 - 15:01 #4
hathor >> Heller  ikke hvis jeg smider 100 points oveni?

/ SurferSigurd

PS det er sjovt at bruge et nyt aka hver gang :)
Avatar billede fri-hash Nybegynder
02. marts 2002 - 15:01 #5
du mangler at escape et par "-er

<td><font face=verdana size=2><input type=\"button\" name=\"button\" onClick=\"window.open('test.php?action=\" . $member['name'] . \"', 'toolbar=no,location=no,status=no,width=200,height=200')</font></td>
Avatar billede neo_bill Nybegynder
02. marts 2002 - 15:07 #6
Nice det virker jo fri-hash...
Avatar billede fri-hash Nybegynder
02. marts 2002 - 15:09 #7
s'følig :-)

takker for points
Avatar billede neo_bill Nybegynder
02. marts 2002 - 15:19 #8
Selv  tak!

Jeg har stenet med det der problem i lang tid nu :( det er  ret irriterende at jeg næsten aldrig kan se mine EGNE fejl selvom de er ultra indlysende....

/ B
Avatar billede tipsen Nybegynder
02. marts 2002 - 16:00 #9
neo_bill: Kig evt. på validator.w3.org - den kan validere din html-kode - der er fortsat en del fejl og mangler på den url du angav ovenfor - forudsat, at den valideres efter HTML 4.01 Transitional!
Avatar billede Ny bruger Nybegynder

Din løsning...

Tilladte BB-code-tags: [b]fed[/b] [i]kursiv[/i] [u]understreget[/u] Web- og emailadresser omdannes automatisk til links. Der sættes "nofollow" på alle links.

Loading billede Opret Preview
Kategori
Vi tilbyder markedets bedste kurser inden for webudvikling

Log ind eller opret profil

Hov!

For at kunne deltage på Computerworld Eksperten skal du være logget ind.

Det er heldigvis nemt at oprette en bruger: Det tager to minutter og du kan vælge at bruge enten e-mail, Facebook eller Google som login.

Du kan også logge ind via nedenstående tjenester