The best solution is really dependant on a number of factors and without a full understanding of your application its not easy to decide.
Is the main form and sub form linked through Linked childfield/master field, if so then I don't see the need to change sub forms record source, or filter property.
If your not using Linked childfield/master fields then the next question is why do you need code in module to manipulate the sub form?
There is nothing wrong in changing the forms recordsource in code like you are doing, I have used a similar method many times.
You need to base the combo's row source on a query and in the query have the criteria call a public global function which returns the ProduktNavn, or the criteria needs to reference an object on the form containing the Produktnavn
Tilladte BB-code-tags: [b]fed[/b] [i]kursiv[/i] [u]understreget[/u] Web- og emailadresser omdannes automatisk til links. Der sættes "nofollow" på alle links.