Avatar billede fredand Forsker
18. november 2003 - 21:13 Der er 11 kommentarer og
1 løsning

Why private and get and Set?

Hello!

Every body has read that you should incapsulate your mambers as god as you can if possible. Instead of public members you should declare them private and create get and set methods. But if you have this class:

public class A
{
    private String a;
   
    public String getA()
    {
        return a
    }
   
    public void setA(String a)
    {
        this.a = a;
    }
}

//and

public class B
{
    public String b;
}

I would say that for safety and memory reson this would be equal The memory would be the same (If instans of class A would be garbage collected we still have refereces to object a):

A classA;
B classB;
//...
classB.b = "Hello";
String j = classB.b;
//or
classA.setA("Hello");
String i = classA.getA();

Please correct me if I am wrong?

If you would have something like this it would be better:
public class A
{
    private String a;
   
    public String getA()
    {
        return a.clone();
    }
   
    public void setA(String a)
    {
        this.a = a.clone();
    }
}

Now if the instans of A would be gb the object a also would go.

So please correct me if I am wrong when I say that the first code of A wouldn't be any better then the code of B. Or is there any other performance or safety winning of coding like A?

Best regards
Fredrik

PS Please give ansvers so you could get part of the points
Avatar billede jakoba Nybegynder
18. november 2003 - 21:30 #1
fordi at det gør get og set til den eneste vej den variabel kan ændre værdi.

så du kan sætte diverse kontroller på:

public class A
{
    private int alder;
 
    public int getA()
    {   
        return alder;
    }
 
    public void setA(int a)
    {
        if ( alder >= 0 && alder < 125 ) {
            this.alder = a;
        } else {
            System.out.println( "fejl. forsøg på at sætte en lovlig usandsynlig alder." );
    }
}

PS: der er ingen grund til nogensidende at clone en String. String objektet kan ikke få ændret den værdi det blev skabt med.

mvh JakobA
Avatar billede jakoba Nybegynder
18. november 2003 - 21:35 #2
Jeg mangler en } i set-metoden.
Avatar billede jakoba Nybegynder
18. november 2003 - 21:45 #3
det var så kun en begrundelsen for set metoden.

nedenfor behøver vi ikke at ane om klassen A indeholder fødeår eller Alder eller noget helt tredie. vi får blot den værdi vi beder om med den valgte get___ metode

public class A
{
    private int foedeAar;
        // fødeår ændres ikke selvom vi har den person i vor database i flere år.

    public int getAlder() { 
        return datoNow() - foedeAar;  // 
    }
    public int getFoedeAar() {
        return FoedeAar
    }

    public void setAlder(int a) {
        if ( alder >= 0 && alder < 125 ) {
            this.foedeAar = datoNow() -a;
        } else {
            System.out.println( "fejl. forsøg på at sætte en lovlig usandsynlig alder." );
        }
    }
    // vi kunne også lave en setFoedeAar metode til at sætte vor variabel (med en tilsvarende test)
}
Avatar billede arne_v Ekspert
18. november 2003 - 21:48 #4
B will actually be faster than A in non-sophisticated JVM's.

But A is still the preferred object oriented solution.

The keyword here is encapsulation.

If you declare members public you can not change the implementation.

Example:

public int zipcode;

works fine in Denmark, but then you need to support other countries
which uses letters.

Ughhh.

private int zipcode;
public int getZipcode() { return zipcode; }
public void setZipcode(int zipcode) { this.zipcode = zipcode; }

could be changed to:

private String zipcode;
public int getZipcode() { return Integer.parseInt(zipcode); }
public void setZipcode(int zipcode) { this.zipcode = Integer.toString(zipcode); }
public int getZipcodeStr() { return zipcode; }
public void setZipcode(String zipcode) { this.zipcode = zipcode; }

which would enable new functionality and keep old code working.

Another big object oriented problem is that members can not be
overriden by sub classes, but members can.

Also here prvate+get+set provides more flexibility to extend
functionality (by making a subclass possible).

Jakob has mentioned the possibility of putting data checks in. Which
is very practical.
Avatar billede fredand Forsker
19. november 2003 - 09:27 #5
Hello mates!

So the conclusion is that using private members and get and set methods would give us:
better flexibilty like data checks
no overrids by subclasses

But there is no guarantee that the memory or processing would be better.

Do you agree ?

I still wonder about the safety-reson, is there any safty-reason that I should use private members and get and set instead of public members? I am pretty sure that I have read that safety should be an issue for this.

Best regards
Fredrik
But please give answers so I could give you the points that you guys really deserve!
Avatar billede arne_v Ekspert
19. november 2003 - 10:12 #6
The other way around - get and set allows for overide by sub classes.

I am not quite sure what you mean by safety reasons. It is a
software programming issue not a runtime system security thing.
Avatar billede arne_v Ekspert
19. november 2003 - 10:12 #7
answer
Avatar billede fredand Forsker
19. november 2003 - 11:44 #8
Hmm!

Perhaps you could give a small note or example what you mean by "It is a
software programming issue" when you say safety reasons. It sounds really interesting!

Best regards
Fredrik
Avatar billede arne_v Ekspert
19. november 2003 - 12:34 #9
It is not.

I am just saying that it is an issue more related to how to write
Java programs in a good way to minimize maintenance costs.

It is not a traditional security issue where one approach will make
teh application vulnerable to hackers or something like that.
Avatar billede fredand Forsker
19. november 2003 - 16:10 #10
Ok!
I see!

Thanks!
Fredrik
Avatar billede arne_v Ekspert
19. november 2003 - 16:20 #11
I think Jacob got cheated regarding points ...
Avatar billede jakoba Nybegynder
19. november 2003 - 16:26 #12
næe, jeg ku have lagt et svar
Avatar billede Ny bruger Nybegynder

Din løsning...

Tilladte BB-code-tags: [b]fed[/b] [i]kursiv[/i] [u]understreget[/u] Web- og emailadresser omdannes automatisk til links. Der sættes "nofollow" på alle links.

Loading billede Opret Preview
Kategori
Kurser inden for grundlæggende programmering

Log ind eller opret profil

Hov!

For at kunne deltage på Computerworld Eksperten skal du være logget ind.

Det er heldigvis nemt at oprette en bruger: Det tager to minutter og du kan vælge at bruge enten e-mail, Facebook eller Google som login.

Du kan også logge ind via nedenstående tjenester