Forbedring af sikkerhed i login system
Okay jeg har dette login system:Login siden:
<?php
session_start();
?>
<head>
<title> ..:: Admin-Login ::..</title>
<link rel="stylesheet" type="text/css" href="style.css">
</head>
<body style="margin-top: 15px;">
<?php
include('config.php');
$result = mysql_query("SELECT * FROM members");
if (mysql_num_rows($result) == 0) {
if (!isset($_POST['send'])) {
echo "
<span class=header>Opret admin konto:</span><br /><br />
<div style='width: 210px; border: 1px solid #797979;'>
<table class=indhold>
<tr>
<td>
<form action=".$_SERVER['PHP_SELF']."?page=opret method=post>
Username:<br>
</td>
</tr>
<tr>
<td>
<input type=text name=username size=30 maxlength=30><br>
</td>
</tr>
<tr>
<td>
Password:<br>
</td>
</tr>
<tr>
<td>
<input type=password name=password size=30 maxlength=30><br>
</td>
</tr>
<tr>
<td>
Indtast Password igen:<br />
</td>
</tr>
<tr>
<td>
<input type=password name=password2 size=30 maxlength=30><br>
</td>
</tr>
<tr>
<td align=center>
<input type=submit name=send value=Opret>
</form>
</td>
</tr>
</table>
</div>
";
}
else {
switch($_GET['page']) {
case opret:
$username = $_POST['username'];
$password = $_POST['password'];
$password2 = $_POST['password2'];
if ($username == "" || $password == "" || $password2 == "") {
echo "Brugernavnet og passwordet skal indeholde mindst et tegn. <br />";
echo "<a href=admin.php>Tilbage</a>";
}
else {
if ($password == $password2) {
$kryptname = md5($username);
$kryptpass = md5($password);
include('config.php');
mysql_query("
INSERT INTO members
(Password,
Username)
VALUES
('$kryptpass',
'$kryptname')
") or die(mysql_error());
echo "Admin kontoen er nu oprettet. <br />";
echo "<a href=admin.php>Login</a>";
}
else {
echo "De to passwords er ikke ens. <br />";
echo "<a href=admin.php>Tilbage</a>";
}
}
}
}}
else {
if (!isset($_POST['send'])) {
echo "
<span class=header>Login:</span><br /><br />
<div style='width: 210px; border: 1px solid #797979;'>
<table class=indhold>
<tr>
<td>
<form action=".$_SERVER['PHP_SELF']." method=post>
</td>
</tr>
<tr>
<td>
Username:<br>
</td>
</tr>
<tr>
<td>
<input type=text name=name size=30 maxlength=30><br>
</td>
</tr>
<tr>
<td>
Password:<br>
</td>
</tr>
<tr>
<td>
<input type=password name=pass size=30 maxlength=30><br>
</td>
</tr>
<tr>
<td align=center>
<input type=submit name=send value=Login>
</form>
</td>
</tr>
</table>
</div>
";
}
else {
$password = $_POST['pass'];
$username = $_POST['name'];
if ($password == "" || $username == "") {
echo "Brugernavn og password skal være på mindst et tegn.<br />";
echo "<a href=admin.php>Tilbage</a>";
}
else
{
$kryptuser = md5($username);
$kryptpass = md5($password);
include('config.php');
$result = mysql_query("SELECT * FROM members WHERE Username = '$kryptuser'") or die(mysql_error());
if (mysql_num_rows($result) == 0) {
echo "The username does not exist!<br />";
echo "<a href=admin.php>Tilbage</a>";
}
else {
while ($row = mysql_fetch_array($result)) {
$check = $row["Password"];
}
if ($kryptpass == $check) {
$_SESSION['username'] = $kryptuser;
$_SESSION['password'] = $kryptpass;
echo "<meta http-equiv=refresh content=0;URL=administrations_panel.php>";
} else {
echo "Login failed! Please try again.";
}
}}
}
}
?>
Og dette tjekker på hver side om sessionen stadig er korrekt:
<?php
session_start();
include('config.php');
$result = mysql_query("SELECT * FROM members WHERE Username = '".$_SESSION['username']."'");
while ($row = mysql_fetch_array($result)) {
$checkpass = $row["Password"];
$checkuser = $row["Username"];
}
if ((empty($result)) OR (empty($checkpass)) OR (empty($checkuser)) OR ($checkpass != $_SESSION['password']) OR ($checkuser != $_SESSION['username']) ) {
session_destroy();
echo "<meta http-equiv=refresh content=0;URL=admin.php>";
exit;
}
else
{
echo "
//og så kommer sidens indhold
";
}
?>
Okay sagen er den at jeg gerne vil have sikkerheden helt i top her. Så de 105 point (hvad jeg havde tilbage) vil blive delt mellem alle dem der kan finde sikkerheds huller og komme med rette lser til disse. Jo flere du finder jo flere point får du :)
