Avatar billede mvk Nybegynder
11. februar 2005 - 11:09 Der er 9 kommentarer og
1 løsning

Mail script virker ikke som om det kører

er der nogen som kan se hvad der er galt med det:

<%@LANGUAGE="VBSCRIPT"%>
<%Server.Scripttimeout=3600%>
<!--#include file="../Connections/gutternes.asp" -->
<%
Dim rsMail__MMColParam
rsMail__MMColParam = "1"
If (Request.QueryString("IDthread") <> "") Then
  rsMail__MMColParam = Request.QueryString("IDthread")
End If
%>
<%
Dim rsMail
Dim rsMail_numRows

Set rsMail = Server.CreateObject("ADODB.Recordset")
rsMail.ActiveConnection = MM_gutternes_STRING
rsMail.Source = "SELECT *  FROM thread, users  WHERE IDthread = " + Replace(rsMail__MMColParam, "'", "''") + " AND Mail = 'Y' AND userID=IDuser  ORDER BY IDuser ASC"
rsMail.CursorType = 0
rsMail.CursorLocation = 2
rsMail.LockType = 1
rsMail.Open()

rsMail_numRows = 0
%>
<%

'Så bliver loopet sådan
if (rsMail.BOF or rsMail.EOF) then

'    Response.Write ("Slut")
    scriptdone = "ja"

else

  on error resume next
  Do While Not rsMail.EOF

        strEmail = (rsMail.Fields.Item("Email_work").Value)
        strNavn  = (rsMail.Fields.Item("Name").Value)
        strHead  = (rsMail.Fields.Item("Headline").Value)
        Set JMail              = Server.CreateObject("JMail.SMTPMail")
        JMail.ServerAddress     = "websmtp.gutternes.dk"
        JMail.Sender            = "admin@gutternes.dk"
        JMail.SenderName          = "Gutternes"
        JMail.ContentType      = "text/html"
        JMail.Subject          = "There is a new post in "
        JMail.AddRecipientBCC    strEmail
        JMail.Priority          = 3
        JMail.AddHeader        "Originating-IP", Request.ServerVariables("REMOTE_ADDR")

JMail.Body = "<font size='2' face='Verdana'>" &_
"Hi " &_
(rsMail.Fields.Item("Name").Value) &_
"<br>" &_
"<br>" &_
"There has been made a new post for " &_
(rsMail.Fields.Item("Headline").Value) &_
" at " &_
(rsMail.Fields.Item("CreateDate").Value) &_
", " &_
(rsMail.Fields.Item("CreateTime").Value) &_
"<br>" &_
"<br>" &_
"Visit the site to check it out" &_
"<br>" &_
"<a href=http://www.gutternes.dk><strong>www.gutternes.dk</strong></a>" &_
"</font>"

        JMail.Body = JMail.Body
        JMail.Execute
        Set JMail = Nothing

      rsMail.Movenext
  Loop
    scriptdone = "nej"
End if
%>
<html>
<head>
<title>script</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
</body>
</html>
<%
rsMail.Close()
Set rsMail = Nothing
%>
<%
if scriptdone <> "ja" then
Response.Write("dope")
'Response.Redirect("http://www.gutternes.dk/forum_specific.asp?IDthread=" & (rsMail.Fields.Item("IDthread").Value))
end if
%>
Avatar billede and_ Nybegynder
11. februar 2005 - 12:14 #1
Nu har jeg prøvet at rydde lidt op i koden...!

Du laver kagemand i din opbygning af bodyteksten i mailen...
Du skal huske at bruge enten et enkelt pling ' eller dobbeltgås "" som afgrænser i dine tags....

Det der er sket er at du bruger "_blank" i din response.write... Så bliver din streng afsluttet... Jeg har skfitet den ud med plinger men du kunne også have brugt "" som escaper til en enkelt, når koden skrives ud...

Derefter kager du i linket... Det har jeg rettet til!

<%@LANGUAGE="VBSCRIPT"%>
<%Server.Scripttimeout=3600%>
<!--#include file="../Connections/gutternes.asp" -->
<%
Dim rsMail__MMColParam
rsMail__MMColParam = "1"
If (Request.QueryString("IDthread") <> "") Then
  rsMail__MMColParam = Request.QueryString("IDthread")
End If

Dim rsMail
Dim rsMail_numRows

Set rsMail = Server.CreateObject("ADODB.Recordset")
rsMail.ActiveConnection = MM_gutternes_STRING
rsMail.Source = "SELECT *  FROM thread, users  WHERE IDthread = " + Replace(rsMail__MMColParam, "'", "''") + " AND Mail = 'Y' AND userID=IDuser  ORDER BY IDuser ASC"
rsMail.CursorType = 0
rsMail.CursorLocation = 2
rsMail.LockType = 1
rsMail.Open()

rsMail_numRows = 0

'Så bliver loopet sådan
if not (rsMail.BOF or rsMail.EOF) then
    on error resume next
    while not rsMail.eof

        'Lav bodytekst... husk enten at bruge pling ' eller dobbetlgås ""
        mailtxt = "<font size='2' face='Verdana'>"
        mailtxt = mailtxt & "Hi " & (rsMail.Fields.Item("Name").Value)
        mailtxt = mailtxt & "<br><br>There has been made a new post for " & (rsMail.Fields.Item("Headline").Value)
        mailtxt = mailtxt & " at " & (rsMail.Fields.Item("CreateDate").Value) & ", " & (rsMail.Fields.Item("CreateTime").Value)
        mailtxt = mailtxt & "<br><br>Visit the site to check it out<br>"
        mailtxt = mailtxt & "<a href='http://www.gutternes.dk' target='_blank'><strong>www.gutternes.dk</strong></a></font>"
        strEmail = (rsMail.Fields.Item("Email_work").Value)
        strNavn  = (rsMail.Fields.Item("Name").Value)
        strHead  = (rsMail.Fields.Item("Headline").Value)

        Set JMail              = Server.CreateObject("JMail.SMTPMail")
        JMail.ServerAddress    = "websmtp.gutternes.dk"
        JMail.Sender            = "admin@gutternes.dk"
        JMail.SenderName          = "Gutternes"
        JMail.ContentType      = "text/html"
        JMail.Subject          = "There is a new post in "
        JMail.AddRecipientBCC    strEmail
        JMail.Priority          = 3
        JMail.AddHeader        "Originating-IP", Request.ServerVariables("REMOTE_ADDR")
        JMail.Body = mailtxt
        JMail.Execute
        Set JMail = Nothing

        rsMail.Movenext
    wend
End if
rsMail.Close()
Set rsMail = Nothing
%>
<html>
<head>
<title>script</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<%
Response.Write("dope")
'Response.Redirect("http://www.gutternes.dk/forum_specific.asp?IDthread=" & (rsMail.Fields.Item("IDthread").Value))
%>
</body>
</html>
Avatar billede mvk Nybegynder
11. februar 2005 - 15:04 #2
er der nogen måde jeg kan udskive resultat på for den sender ikke nogen mails og jeg burde modtage en hvis det virker.

link: http://www.gutternes.dk/include/forum_script.asp?IDthread=1012
Avatar billede and_ Nybegynder
11. februar 2005 - 15:10 #3
upload lige det her og sig til, så kigger jeg lige :p

<%@LANGUAGE="VBSCRIPT"%>
<%Server.Scripttimeout=3600%>
<!--#include file="../Connections/gutternes.asp" -->
<%
Dim rsMail__MMColParam
rsMail__MMColParam = "1"
If (Request.QueryString("IDthread") <> "") Then
  rsMail__MMColParam = Request.QueryString("IDthread")
End If

Dim rsMail
Dim rsMail_numRows

Set rsMail = Server.CreateObject("ADODB.Recordset")
rsMail.ActiveConnection = MM_gutternes_STRING
rsMail.Source = "SELECT *  FROM thread, users  WHERE IDthread = " + Replace(rsMail__MMColParam, "'", "''") + " AND Mail = 'Y' AND userID=IDuser  ORDER BY IDuser ASC"
rsMail.CursorType = 0
rsMail.CursorLocation = 2
rsMail.LockType = 1
rsMail.Open()

rsMail_numRows = 0

'Så bliver loopet sådan
if not (rsMail.BOF or rsMail.EOF) then
    response.write("Basen er ikke tom!<br>")
    i = 0
    on error resume next
    while not rsMail.eof
        response.write("Starter løkke!<br>")
        'Lav bodytekst... husk enten at bruge pling ' eller dobbetlgås ""
        mailtxt = "<font size='2' face='Verdana'>"
        mailtxt = mailtxt & "Hi " & (rsMail.Fields.Item("Name").Value)
        mailtxt = mailtxt & "<br><br>There has been made a new post for " & (rsMail.Fields.Item("Headline").Value)
        mailtxt = mailtxt & " at " & (rsMail.Fields.Item("CreateDate").Value) & ", " & (rsMail.Fields.Item("CreateTime").Value)
        mailtxt = mailtxt & "<br><br>Visit the site to check it out<br>"
        mailtxt = mailtxt & "<a href='http://www.gutternes.dk' target='_blank'><strong>www.gutternes.dk</strong></a></font>"
        strEmail = (rsMail.Fields.Item("Email_work").Value)
        strNavn  = (rsMail.Fields.Item("Name").Value)
        strHead  = (rsMail.Fields.Item("Headline").Value)

        Set JMail              = Server.CreateObject("JMail.SMTPMail")
        JMail.ServerAddress    = "websmtp.gutternes.dk"
        JMail.Sender            = "admin@gutternes.dk"
        JMail.SenderName          = "Gutternes"
        JMail.ContentType      = "text/html"
        JMail.Subject          = "There is a new post in "
        JMail.AddRecipientBCC    strEmail
        JMail.Priority          = 3
        JMail.AddHeader        "Originating-IP", Request.ServerVariables("REMOTE_ADDR")
        JMail.Body = mailtxt
        JMail.Execute
        Set JMail = Nothing

        rsMail.Movenext
        i = i + 1
    wend
End if
rsMail.Close()
Set rsMail = Nothing
%>
<html>
<head>
<title>script</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>
<body>
<%
response.write("løkke er kørt " & i & " gange!<br>")
Response.Write("dope")
'Response.Redirect("http://www.gutternes.dk/forum_specific.asp?IDthread=" & (rsMail.Fields.Item("IDthread").Value))
%>
</body>
</html>
Avatar billede and_ Nybegynder
11. februar 2005 - 15:16 #4
løkke er kørt gange!
dope

Ingen output, så den kører jo ikke løkken!
sikker på at der er indhold?
Avatar billede and_ Nybegynder
11. februar 2005 - 15:24 #5
<%@LANGUAGE="VBSCRIPT"%>
<%Server.Scripttimeout=3600%>
<!--#include file="../Connections/gutternes.asp" -->
<html>
    <head>
        <title>script</title>
        <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
    </head>
<body>
<%
Dim rsMail__MMColParam
rsMail__MMColParam = "1"
If (Request.QueryString("IDthread") <> "") Then
  rsMail__MMColParam = Request.QueryString("IDthread")
End If

Dim rsMail
Dim rsMail_numRows

Set rsMail = Server.CreateObject("ADODB.Recordset")
rsMail.ActiveConnection = MM_gutternes_STRING
rsMail.Source = "SELECT *  FROM thread, users  WHERE IDthread = " & Replace(rsMail__MMColParam, "'", "''") & " AND Mail = 'Y' AND userID = IDuser ORDER BY IDuser ASC"
rsMail.CursorType = 0
rsMail.CursorLocation = 2
rsMail.LockType = 1
rsMail.Open()

rsMail_numRows = 0

response.write("Script start<br>")
response.write("SQL: " & "SELECT *  FROM thread, users  WHERE IDthread = " & Replace(rsMail__MMColParam, "'", "''") & " AND Mail = 'Y' AND userID = IDuser ORDER BY IDuser ASC<br><br>")

'Loopie Louie :p
if not (rsMail.BOF or rsMail.EOF) then

    i = 0
    response.write("  Basen er ikke tom!<br>")

    on error resume next
    while not rsMail.eof
        if i = 0 then
            response.write("    Starter løkke!<br>")
        end if
        response.write("      Brugeren: " & (rsMail.Fields.Item("Name").Value) & "<br>")
        'Lav bodytekst... husk enten at bruge pling ' eller dobbetlgås ""
        mailtxt = "<font size='2' face='Verdana'>"
        mailtxt = mailtxt & "Hi " & (rsMail.Fields.Item("Name").Value)
        mailtxt = mailtxt & "<br><br>There has been made a new post for " & (rsMail.Fields.Item("Headline").Value)
        mailtxt = mailtxt & " at " & (rsMail.Fields.Item("CreateDate").Value) & ", " & (rsMail.Fields.Item("CreateTime").Value)
        mailtxt = mailtxt & "<br><br>Visit the site to check it out<br>"
        mailtxt = mailtxt & "<a href='http://www.gutternes.dk' target='_blank'><strong>www.gutternes.dk</strong></a></font>"
        strEmail = (rsMail.Fields.Item("Email_work").Value)
        strNavn  = (rsMail.Fields.Item("Name").Value)
        strHead  = (rsMail.Fields.Item("Headline").Value)

        Set JMail              = Server.CreateObject("JMail.SMTPMail")
        JMail.ServerAddress    = "websmtp.gutternes.dk"
        JMail.Sender            = "admin@gutternes.dk"
        JMail.SenderName          = "Gutternes"
        JMail.ContentType      = "text/html"
        JMail.Subject          = "There is a new post in "
        JMail.AddRecipientBCC    strEmail
        JMail.Priority          = 3
        JMail.AddHeader        "Originating-IP", Request.ServerVariables("REMOTE_ADDR")
        JMail.Body = mailtxt
        JMail.Execute
        Set JMail = Nothing

        rsMail.Movenext
        i = i + 1
    wend
End if

response.write("løkke er kørt " & i & " gange!<br>")
'Response.Redirect("http://www.gutternes.dk/forum_specific.asp?IDthread=" & (rsMail.Fields.Item("IDthread").Value))

rsMail.Close()
Set rsMail = Nothing
%>
</body>
</html>
Avatar billede mvk Nybegynder
11. februar 2005 - 15:25 #6
SQL skal se sådan ud:
rsMail.Source = "SELECT *  FROM thread, users  WHERE IDthread = " & Replace(rsMail__MMColParam, "'", "''") & " OR threadID = " + Replace(rsMail__MMColParam, "'", "''") + " AND Mail = 'Y' AND userID = IDuser ORDER BY IDuser ASC"
Avatar billede and_ Nybegynder
11. februar 2005 - 15:45 #7
vi har pt. taget den pr. mail og msn...

Den færdige løsning bliver postet herinde...
Avatar billede and_ Nybegynder
11. februar 2005 - 15:56 #8
Færdigt script:

<%@LANGUAGE="VBSCRIPT"%>
<%Server.Scripttimeout=3600%>
<!--#include file="../Connections/gutternes.asp" -->
<html>
    <head>
        <title>script</title>
        <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
    </head>
<body>
<%
Dim rsMail__MMColParam
rsMail__MMColParam = "1"
If (Request.QueryString("IDthread") <> "") Then
  rsMail__MMColParam = Request.QueryString("IDthread")
End If

Dim rsMail
Dim rsMail_numRows

Set rsMail = Server.CreateObject("ADODB.Recordset")
rsMail.ActiveConnection = MM_gutternes_STRING
rsMail.Source = "SELECT * FROM thread, users WHERE thread.Mail = 'Y' AND (thread.IDthread = " & Replace(rsMail__MMColParam, "'", "''") & " OR thread.threadID = " & Replace(rsMail__MMColParam, "'", "''") & ") AND (thread.userID = users.IDuser) ORDER BY users.IDuser ASC"
rsMail.CursorType = 0
rsMail.CursorLocation = 2
rsMail.LockType = 1
rsMail.Open()
rsMail_numRows = 0

response.write("Script start<br>")
response.write("SQL: " & "SELECT *  FROM thread, users  WHERE IDthread = " & Replace(rsMail__MMColParam, "'", "''") & " AND Mail = 'Y' AND userID = IDuser ORDER BY IDuser ASC<br><br>")

'Loopie Louie :p
if not (rsMail.BOF or rsMail.EOF) then

    'Lav bodytekst... husk enten at bruge pling ' eller dobbetlgås ""
    mailtxt = "<font size='2' face='Verdana'>"
    mailtxt = mailtxt & "Hi " & (rsMail.Fields.Item("Name").Value)
    mailtxt = mailtxt & "<br><br>There has been made a new post for " & (rsMail.Fields.Item("Headline").Value)
    mailtxt = mailtxt & " at " & (rsMail.Fields.Item("CreateDate").Value) & ", " & (rsMail.Fields.Item("CreateTime").Value)
    mailtxt = mailtxt & "<br><br>Visit the site to check it out<br>"
    mailtxt = mailtxt & "<a href='http://www.gutternes.dk' target='_blank'><strong>www.gutternes.dk</strong></a></font>"
    strEmail = (rsMail.Fields.Item("Email_work").Value)
    strNavn  = (rsMail.Fields.Item("Name").Value)
    strHead  = (rsMail.Fields.Item("Headline").Value)

    Set JMail              = Server.CreateObject("JMail.SMTPMail")
    JMail.ServerAddress    = "websmtp.gutternes.dk"
    JMail.Sender            = "admin@gutternes.dk"
    JMail.SenderName          = "Gutternes"
    JMail.ContentType      = "text/html"
    JMail.Subject          = "There is a new post in "
    JMail.AddRecipientBCC    strEmail
    JMail.Priority          = 3
    JMail.AddHeader        "Originating-IP", Request.ServerVariables("REMOTE_ADDR")
    JMail.Body = mailtxt
    JMail.Execute
    Set JMail = Nothing
    response.write("Mail afsendt til " & (rsMail.Fields.Item("Name").Value))
End if
response.write("løkke er kørt " & i & " gange!<br>")
'Response.Redirect("http://www.gutternes.dk/forum_specific.asp?IDthread=" & (rsMail.Fields.Item("IDthread").Value))
rsMail.Close()
Set rsMail = Nothing
%>
</body>
</html>
Avatar billede mvk Nybegynder
14. februar 2005 - 21:18 #9
u the best motherfucking Duck in the world!
Avatar billede and_ Nybegynder
14. februar 2005 - 21:18 #10
helt færdige script:

<%@LANGUAGE="VBSCRIPT"%>
<!--#include file="../Connections/gutternes.asp" -->
<%Server.Scripttimeout=3600%>
<html>
    <head>
        <title>script</title>
        <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
    </head>
<body>
<%
Dim rsMail__MMColParam
rsMail__MMColParam = "1"
If (Request.QueryString("IDthread") <> "") Then
  rsMail__MMColParam = Request.QueryString("IDthread")
End If

Dim rsThread
Dim rsThread_numRows

Set rsThread = Server.CreateObject("ADODB.Recordset")
rsThread.ActiveConnection = MM_gutternes_STRING
rsThread.Source = "SELECT * FROM thread WHERE IDthread = " & Replace(rsMail__MMColParam, "'", "''") & ""
rsThread.CursorType = 0
rsThread.CursorLocation = 2
rsThread.LockType = 1
rsThread.Open()
rsThread_numRows = 0

Dim rsPoster
Dim rsPoster_numRows

Set rsPoster = Server.CreateObject("ADODB.Recordset")
rsPoster.ActiveConnection = MM_gutternes_STRING
rsPoster.Source = "SELECT * FROM thread, users WHERE threadID = " & Replace(rsMail__MMColParam, "'", "''") & " AND IDuser=userID ORDER BY IDthread DESC"
rsPoster.CursorType = 0
rsPoster.CursorLocation = 2
rsPoster.LockType = 1
rsPoster.Open()
rsPoster_numRows = 0

Dim rsMail
Dim rsMail_numRows

Set rsMail = Server.CreateObject("ADODB.Recordset")
rsMail.ActiveConnection = MM_gutternes_STRING
rsMail.Source = "SELECT * FROM thread, users WHERE thread.Mail = 'Y' AND (thread.IDthread = " & Replace(rsMail__MMColParam, "'", "''") & " OR thread.threadID = " & Replace(rsMail__MMColParam, "'", "''") & ") And users.IDuser=thread.userid ORDER BY users.IDuser ASC<br>"
rsMail.CursorType = 0
rsMail.CursorLocation = 2
rsMail.LockType = 1
rsMail.Open()
rsMail_numRows = 0

response.write("Script start<br>")
response.write("SELECT * FROM thread, users WHERE thread.Mail = 'Y' AND (thread.IDthread = " & Replace(rsMail__MMColParam, "'", "''") & " OR thread.threadID = " & Replace(rsMail__MMColParam, "'", "''") & ") And users.IDuser=thread.userid ORDER BY users.IDuser ASC<br>")

'Loopie Louie :p
while not rsmail.eof
    'Lav bodytekst... husk enten at bruge pling ' eller dobbetlgås ""
    mailtxt = "<font size='2' face='Verdana'>"
    mailtxt = mailtxt & "Hi " & (rsMail.Fields.Item("Name").Value)
    mailtxt = mailtxt & "<br><br>There has been made a new post for " & (rsThread.Fields.Item("Headline").Value)
    mailtxt = mailtxt & "<br><br>The topic is '" & (rsMail.Fields.Item("Headline").Value) & "'"
    mailtxt = mailtxt & " and it was created at " & (rsMail.Fields.Item("CreateDate").Value) & ", " & (rsMail.Fields.Item("CreateTime").Value)
    mailtxt = mailtxt & "<br>The post was made by " & (rsPoster.Fields.Item("Name").Value)
    mailtxt = mailtxt & "<br><br>Visit the site to check it out<br>"
    mailtxt = mailtxt & "<a href='http://www.gutternes.dk' target='_blank'><strong>www.gutternes.dk</strong></a></font>"
    strEmail = (rsMail.Fields.Item("Email_work").Value)
    strNavn  = (rsMail.Fields.Item("Name").Value)
    strHead  = (rsMail.Fields.Item("Headline").Value)

    Set JMail              = Server.CreateObject("JMail.SMTPMail")
        JMail.ServerAddress    = "localhost"
        JMail.Sender          = "postmaster@gutternes.dk"
        JMail.SenderName      = "Gutternes"
        JMail.ContentType      = "text/html"
        JMail.Subject          = "There is a new post in " & (rsThread.Fields.Item("Headline").Value)
        JMail.AddRecipientBCC    strEmail
        JMail.Priority          = 3
        JMail.AddHeader        "Originating-IP", Request.ServerVariables("REMOTE_ADDR")
        JMail.Body = mailtxt
        JMail.Execute
    Set JMail = Nothing
        response.write("Mail afsendt til " & (rsMail.Fields.Item("Name").Value) & "<br>")

    rsmail.movenext
wend

rsMail.Close()
Set rsMail = Nothing
%>
</body>
</html>
Avatar billede Ny bruger Nybegynder

Din løsning...

Tilladte BB-code-tags: [b]fed[/b] [i]kursiv[/i] [u]understreget[/u] Web- og emailadresser omdannes automatisk til links. Der sættes "nofollow" på alle links.

Loading billede Opret Preview
Kategori
Kurser inden for grundlæggende programmering

Log ind eller opret profil

Hov!

For at kunne deltage på Computerworld Eksperten skal du være logget ind.

Det er heldigvis nemt at oprette en bruger: Det tager to minutter og du kan vælge at bruge enten e-mail, Facebook eller Google som login.

Du kan også logge ind via nedenstående tjenester